-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(files): extract PDF viewer behind SSR boundary and polish file preview #4316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3250264
feat(files): extract PDF viewer behind SSR boundary and polish file p…
waleedlatif1 4d3da79
fix(files): replace instanceof Error checks with toError() and fix sk…
waleedlatif1 809c9d4
fix(files): address PR review findings
waleedlatif1 e794eeb
chore(files): revert accidental pptxgenjs.cjs re-minification
waleedlatif1 a05542a
fix(files): fix Monaco stale closure, XLSX Ctrl+S data loss, and asyn…
waleedlatif1 9f34a27
refactor(files): cleanup anti-patterns across file viewer components
waleedlatif1 773992b
improvement(files): replace stock Monaco theme with Sim design system…
waleedlatif1 d37a74b
fix(files): bump light theme comment color to #888888 for WCAG contrast
waleedlatif1 7de86d6
fix(files): fix dark mode comment contrast #4a4a4a → #606060 (~1.9:1 …
waleedlatif1 638dfc3
improvement(files): cursor to default color, video background to surf…
waleedlatif1 14f77b3
fix(files): stabilize setInputRef callback and guard against double-c…
waleedlatif1 8cec4a3
fix(files): preserve scroll position during Mothership streaming edits
waleedlatif1 a252ab4
fix(files): fix two scroll logic bugs introduced in previous streamin…
waleedlatif1 bdae6d3
chore(files): remove extraneous comments from file viewer and data table
waleedlatif1 4d6657b
refactor(files): split 2281-line file-viewer.tsx into focused modules
waleedlatif1 deec713
fix(files): remove unnecessary TextEditorProps export
waleedlatif1 f1d837d
refactor(files): four stellar-quality improvements to file-viewer split
waleedlatif1 bf6e630
test(files): extract pure modules and add 122-test suite for file vie…
waleedlatif1 12f746a
fix(files): add key to IframePreview and use monotonic seq for stream…
waleedlatif1 a579b85
fix(files): restore getFileExtension import dropped during refactor
waleedlatif1 87aa8f6
fix(files): clear loadError on PDF success and fix streaming null-flash
waleedlatif1 68aeb69
refactor(files): cleanup pass — effect, callback, state, and design f…
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.