Refactor: Extract replaceIdentifierReferences and remove reliance on this in ASTCallbacks

[LalitNarayanYadav]

Addresses #8694

Changes:

• Extracted replaceIdentifierReferences from ASTCallbacks into a standalone helper function
• Removed reliance on this binding within ASTCallbacks
• Replaced all this.replaceIdentifierReferences(...) calls with direct function calls
• Updated internal callback references (e.g., BinaryExpression, AssignmentExpression) to use explicit ASTCallbacks references
• Removed the inline helper implementation from ASTCallbacks

This improves modularity and makes the code easier to reason about, while preserving existing behavior.

---

Screenshots of the change:

N/A (non-visual refactor)

---

PR Checklist

• npm run lint passes
• Inline reference is included / updated
• Unit tests are included / updated

[LalitNarayanYadav]

This is the first incremental refactor PR for #8694.

I’ve focused on extracting replaceIdentifierReferences out of ASTCallbacks and removing reliance on this binding, without changing any transformation logic.

The goal is to make the code easier to reason about and prepare for further cleanup in smaller, reviewable steps.

Next steps (planned incremental PRs):

• Deduplicate BinaryExpression / LogicalExpression handling
• Introduce a guarded callback wrapper to reduce repeated ancestor checks
• Extract shared helpers used in control flow transformations
• Add a high-level pipeline documentation block

Happy to adjust the approach based on feedback before proceeding further.

[p5-bot]

Continuous Release

CDN link

• https://raw.esm.sh/pr/p5@56b0b4a/lib/p5.min.js

Published Packages

• https://pkg.pr.new/p5@56b0b4a

Commit hash: 370b85e

Previous deployments

5996f67

• https://raw.esm.sh/pr/p5@75d29d0/lib/p5.min.js
• https://pkg.pr.new/p5@75d29d0

---

This is an automated message.

[davepagurek]

Looks good!