Implement notification loop safeguard in ofParameter<void>#7122
Open
eduardfrigola wants to merge 2 commits intoopenframeworks:masterfrom
Open
Implement notification loop safeguard in ofParameter<void>#7122eduardfrigola wants to merge 2 commits intoopenframeworks:masterfrom
eduardfrigola wants to merge 2 commits intoopenframeworks:masterfrom
Conversation
54 tasks
This was referenced Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #6602 this PR makes
ofParameter<void>behave the same way as the rest of parameters does.As it is a template specialisation, the code proposed in this pull request is just coping the same functionality as is already implemented for the general
ofParametertemplate.openFrameworks/libs/openFrameworks/types/ofParameter.h
Lines 726 to 766 in 977cbf3
This pull request does not address the fact that, implementing the same functionality twice, makes the code more prone to errors, and makes you responsible on checking differences in behaviour between the template and the specialisation when some changes are made. For that matter I feel a separate PR could be more clean.