Progress on #5440 (Backward compatibility for glm / vec transition).#5593
Progress on #5440 (Backward compatibility for glm / vec transition).#5593bakercp wants to merge 2 commits intoopenframeworks:masterfrom
Conversation
bakercp
changed the title
| /// \} | ||
|
|
||
| #ifndef OF_USE_LEGACY_MESH | ||
| OF_DEPRECATED_MSG("Use glm::vec2.", ofMesh_(ofPrimitiveMode mode, const vector<ofVec2f>& verts)); |
There was a problem hiding this comment.
I don't think we should have these, if someone needs this level of compatibility i think it's better to enable legacy mode in ofConstants. you cna still use glm in your project and even create ofMeshglm::vec3 or polylines and old addons... wil work right away.
Mostly i don't think we should be creating a lot of new deprecated methods
There was a problem hiding this comment.
Well, technically, we aren't adding new deprecated methods ... these are all methods that currently exist in 0.9.* and have not been gracefully deprecated, but rather hidden behind a somewhat unintuitive OF_USE_LEGACY_MESH def. I say unintuitive based on my experiences with many students this past semester trying to mix old and new addons. Huge amounts of time were consumed trying to figure out the right combination of using OF_USE_LEGACY_MESH or converting addons, to glm.
So, basically I'd strongly argue for formally deprecating these by default to ease the transition, especially with the very heterogeneous state of addons.
…orks into improved-glm-support
|
@arturoc Do you have additional thoughts on this? |
2 participants
Adds better backward compatibility during the
glm::vec*/ofVec*transition.