fixes for ofxOsc#5026
Open
tpltnt wants to merge 10 commits intoopenframeworks:masterfrom
Open
Conversation
Contributor
|
What does this fix? It only failes because of the casting on 64bit systems |
Contributor
Author
|
@underdoeg this PR was supposed to fix a few (implicit) problems like missing initializations etc. Yes, it is currently failing since I did not had the time to continue working on it. It was working on my machine at some point, but was (rightfully) stopped by the integration tests. Do you want me to continue on it? (I would re-prioritize it then) |
| { | ||
| ofLogWarning("ofxOscMessage") << "getArgAsInt32(): converting float to int32 for argument " << index; | ||
| return (std::int32_t)((ofxOscArgFloat*)args[index])->get(); | ||
| return reinterpret_cast<std::int32_t> (dynamic_cast<ofxOscArgFloat*> args[index])->get(); |
Contributor
There was a problem hiding this comment.
maybe:
return reinterpret_cast<std::int32_t> ((dynamic_cast<ofxOscArgFloat*> (args[index]))->get());
now, this line is interpreted like:
return (reinterpret_cast<std::int32_t> (dynamic_cast<ofxOscArgFloat*> (args[index])))->get();
Contributor
Author
|
thanks for pointing it out @2bbb, but it doesn't seem to be the only issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
i took a look at ofxOsc and fixed a few issues.
Cheers,
tpltnt