Skip to content

Improve control on custom icon display on login page#3123

Open
weilai-irl wants to merge 2 commits intowip-125751-m405from
wip-127712-m405
Open

Improve control on custom icon display on login page#3123
weilai-irl wants to merge 2 commits intowip-125751-m405from
wip-127712-m405

Conversation

@weilai-irl
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings April 27, 2026 19:27
@weilai-irl weilai-irl self-assigned this Apr 27, 2026
@weilai-irl weilai-irl added this to the 2026-02 milestone Apr 27, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds admin control over whether the OpenID Connect provider icon (including custom icon uploads) is shown on the Moodle login page, and improves settings UX by conditionally hiding logout endpoint configuration when single sign-out is disabled.

Changes:

  • Added a new admin checkbox to control whether an icon is shown on the login page, and conditionally hides the icon/custom icon settings when disabled.
  • Updated the authcode login flow to respect the new “show icon” config.
  • Hid the IdP logout endpoint setting unless single sign-out is enabled.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
auth/oidc/settings.php Adds the new “show icon” checkbox and hide/show rules for icon-related settings; hides logout URI when SSO-off is disabled.
auth/oidc/lang/en/auth_oidc.php Adds the language string for the new checkbox label.
auth/oidc/classes/loginflow/authcode.php Implements runtime behavior change to show/hide icons based on the new config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread auth/oidc/settings.php Outdated
Comment thread auth/oidc/settings.php Outdated
Comment thread auth/oidc/classes/loginflow/authcode.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants