Improve control on custom icon display on login page#3123
Open
weilai-irl wants to merge 2 commits intowip-125751-m405from
Open
Improve control on custom icon display on login page#3123weilai-irl wants to merge 2 commits intowip-125751-m405from
weilai-irl wants to merge 2 commits intowip-125751-m405from
Conversation
There was a problem hiding this comment.
Pull request overview
Adds admin control over whether the OpenID Connect provider icon (including custom icon uploads) is shown on the Moodle login page, and improves settings UX by conditionally hiding logout endpoint configuration when single sign-out is disabled.
Changes:
- Added a new admin checkbox to control whether an icon is shown on the login page, and conditionally hides the icon/custom icon settings when disabled.
- Updated the authcode login flow to respect the new “show icon” config.
- Hid the IdP logout endpoint setting unless single sign-out is enabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| auth/oidc/settings.php | Adds the new “show icon” checkbox and hide/show rules for icon-related settings; hides logout URI when SSO-off is disabled. |
| auth/oidc/lang/en/auth_oidc.php | Adds the language string for the new checkbox label. |
| auth/oidc/classes/loginflow/authcode.php | Implements runtime behavior change to show/hide icons based on the new config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6b851d5 to
38778e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.