AdvLoggerPkg: Update functionality for PeilessSec#877
Draft
apop5 wants to merge 1 commit intomicrosoft:release/202511from
Draft
AdvLoggerPkg: Update functionality for PeilessSec#877apop5 wants to merge 1 commit intomicrosoft:release/202511from
apop5 wants to merge 1 commit intomicrosoft:release/202511from
Conversation
In PeilessSec platforms using a PcdAdvancedLoggerBase at a fixed location, there are other firmware components which may run prior to Uefi and create log messages. Perform a check at the fixed location for a valid log signature. If the valid log signature is found, treat the log buffer as already initialized and then reinitialize the hwdport. Found in a platform where pre UEFI firmware is initializing the log buffer, but using a different serial port from what the Uefi code uses.
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_plus/actions/runs/24916490389 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #877 +/- ##
================================================
Coverage ? 3.08%
================================================
Files ? 36
Lines ? 4247
Branches ? 73
================================================
Hits ? 131
Misses ? 4110
Partials ? 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In PeilessSec platforms using a PcdAdvancedLoggerBase at a fixed location, there are other firmware components which may run prior to Uefi and create log messages.
Perform a check at the fixed location for a valid log signature. If the valid log signature is found, treat the log buffer as already initialized and then reinitialize the hwdport.
Found in a platform where pre UEFI firmware is initializing the log buffer, but using a different serial port from what the Uefi code uses.
How This Was Tested
Physical Platform
Integration Instructions
No integration necessary (changes are backward compatible with existing implementation)