Skip to content

Short circuit by square#345

Open
lohaswinner wants to merge 1 commit intohanabi1224:mainfrom
lohaswinner:pynsieve_shortcircuit
Open

Short circuit by square#345
lohaswinner wants to merge 1 commit intohanabi1224:mainfrom
lohaswinner:pynsieve_shortcircuit

Conversation

@lohaswinner
Copy link
Copy Markdown

About 20% of execution time will be reduced.

About 20% of execution time will be reduced.
@hanabi1224
Copy link
Copy Markdown
Owner

It's a non-goal to make every program most optimized, it's top priority to maintain comparability

@lohaswinner
Copy link
Copy Markdown
Author

lohaswinner commented Jan 6, 2023

It's a non-goal to make every program most optimized, it's top priority to maintain comparability

I can't understand the goal. It's not inconsistent with coro-prime-sieve examples.
In the coro-prime-sieve there are examples that cannot be compared.

This change has only 3 lines changed. So it's not difficult to maintain.
Could you accept PR have changeset for all the language?

@cyrusmsk
Copy link
Copy Markdown
Contributor

It's a non-goal to make every program most optimized, it's top priority to maintain comparability

I think this is an extra logic - and it need to be added to all languages and implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants