-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(auth): Add blocking Regional Access Boundary Lookup and Seed Support #16720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
macastelaz
wants to merge
16
commits into
googleapis:main
Choose a base branch
from
macastelaz:clean-rab-gcloud
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5c3c331
feat(auth): implement blocking lookup flow for regional access boundary
macastelaz c6c140f
style(auth): address lint and formatting issues in regional access bo…
macastelaz b0163b1
fix(auth): restore accidentally removed helper and fix flakiness in s…
macastelaz 17a1c3d
Rename method for internal access boundary seeding
macastelaz 78bd7e6
Update credentials.py
macastelaz 9bbba81
chore(auth): remove redundant get_bool_from_env helper
macastelaz 5a8ad8b
chore(auth): revert accidental changes to _helpers.py
macastelaz 87880a6
chore(auth): remove unused __eq__ implementations
macastelaz ac15926
test(auth): increase coverage for regional access boundary
macastelaz 1872dd1
test(auth): add coverage for real credential types and blocking lookup
macastelaz 28541d4
style(auth): apply black formatting
macastelaz d2258f4
fix: fix failing pickling tests by restoring _rab_manager and adding …
macastelaz a70c23f
test(auth): address RAB feedback with robust coverage and docs
macastelaz bf41e71
style(auth): fix black formatting and typo
macastelaz 4e2bc63
test(auth): fix flaky assertion in test_external_accounts.py
macastelaz d4ab1eb
test(auth): verify no request made when RAB lookup URL is null
macastelaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.