embed: add option for client listener#21672
Conversation
Add an option to provide net.Listeners instead of listen addresses to the embed server. This allows custom transports (including in-memory transports). Applications include new security transports, graceful server restart, and hermetic testing. Fixes etcd-io#10191 Updates etcd-io#17440 Signed-off-by: Ian Gudger <igudger@coreweave.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iangudger The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @iangudger. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
Add an option to provide net.Listeners instead of listen addresses to the embed server. This allows custom transports (including in-memory transports). Applications include new security transports, graceful server restart, and hermetic testing.
Fixes #10191
Updates #17440