add --tls-curve-preferences flag to grpc-proxy#21650
add --tls-curve-preferences flag to grpc-proxy#21650chaitanyabodlapati wants to merge 1 commit intoetcd-io:mainfrom
Conversation
Signed-off-by: chaitanyabodlapati <cbodlapa@netapp.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chaitanyabodlapati The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @chaitanyabodlapati. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Adds a new
--tls-curve-preferencesflag to etcd grpc-proxy, along witha small cleanup of a shadowing local variable.
Motivation
Go 1.24's native FIPS 140-3 mode (
GODEBUG=fips140=only) rejects X25519during TLS handshake. There is currently no way to restrict the
proxy's curve selection, so FIPS-mode deployments cannot use the
grpc-proxy. This PR adds an opt-in flag that restricts curves.
Behavior
--tls-min-version.--tls-min-version/--tls-max-version.Example
etcd grpc-proxy start
--endpoints=https://host:2379
--tls-curve-preferences=P-256,P-384,P-521
Testing
client/pkg/tlsutil.GODEBUG=fips140=only, verified successfulWithout this flag under FIPS mode,
the handshake fails with
crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode.Related