Skip to content

Explicitly set the java toolchain and release version#34

Open
adwsingh wants to merge 1 commit intoaws:mainfrom
adwsingh:main
Open

Explicitly set the java toolchain and release version#34
adwsingh wants to merge 1 commit intoaws:mainfrom
adwsingh:main

Conversation

@adwsingh
Copy link
Copy Markdown
Contributor

@adwsingh adwsingh commented Apr 27, 2026

Please read the Contributing Guidelines before submitting a
pull request. We cannot accept pull requests against the generated models in
this repository

Describe your changes

Without these settings, the Java version declared in Gradle module metadata depends on whatever JAVA_HOME happens to be set on the release machine. This affects consumers that use Gradle's JVM version compatibility checking during dependency resolution.

For example, s3 version 1.0.16 declares org.gradle.jvm.version: 25, which breaks consumers like smithy-java that run on JDK 21. Version 1.0.17 declares JDK 17, presumably because the release host had a different JAVA_HOME. Since these jars only contain Smithy JSON models and no bytecode, the declared JVM version is irrelevant to actual compatibility but Gradle enforces it regardless. I changed it to 8 to maximize compatibility.

Link to the relevant issue(s)

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants