Explicitly set the java toolchain and release version#34
Open
Explicitly set the java toolchain and release version#34
Conversation
mtdowling
approved these changes
Apr 27, 2026
franco2002lu
approved these changes
Apr 27, 2026
sugmanue
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read the Contributing Guidelines before submitting a
pull request. We cannot accept pull requests against the generated models in
this repository
Describe your changes
Without these settings, the Java version declared in Gradle module metadata depends on whatever
JAVA_HOMEhappens to be set on the release machine. This affects consumers that use Gradle's JVM version compatibility checking during dependency resolution.For example,
s3version 1.0.16 declaresorg.gradle.jvm.version: 25, which breaks consumers like smithy-java that run on JDK 21. Version 1.0.17 declares JDK 17, presumably because the release host had a differentJAVA_HOME. Since these jars only contain Smithy JSON models and no bytecode, the declared JVM version is irrelevant to actual compatibility but Gradle enforces it regardless. I changed it to 8 to maximize compatibility.Link to the relevant issue(s)
Checklist