fix: preserve repeated add-dir flags in claude args#1256
Open
Jerry2003826 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: preserve repeated add-dir flags in claude args#1256Jerry2003826 wants to merge 1 commit intoanthropics:mainfrom
Jerry2003826 wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1215
Summary
--add-dirflags parsed fromclaude_args.additionalDirectoriesoption.add-dirfromextraArgsso the SDK does not receive a single overwritten or delimiter-joined value.Root Cause
parseClaudeArgsToExtraArgs()stores CLI flags in a record keyed by flag name. Sinceadd-dirwas not treated as an accumulating flag, repeated values overwrote earlier directories before reaching the SDK.Validation
bun test test/parse-sdk-options.test.ts -t add-dirbun test test/parse-sdk-options.test.tsbun testbun run typecheckbunx prettier --check src/parse-sdk-options.ts test/parse-sdk-options.test.ts