Fixed bugs in invite and dynamic links implementations#524
Fixed bugs in invite and dynamic links implementations#524EddyVerbruggen merged 1 commit intoEddyVerbruggen:masterfrom
Conversation
Added proper iOS 9+ handling for dynamic links Extended returned data to include match confidence (specific for iOS) Updated documentation
|
BTW, this implements dynamicLinkFromUniversalLinkURL so #505 is not needed. |
| appDelegate.prototype.applicationContinueUserActivityRestorationHandler = function (application, userActivity, restorationHandler) { | ||
| var result = false; | ||
|
|
||
| if (typeof(FIRDynamicLink) !== "undefined" ) { |
There was a problem hiding this comment.
This seems a duplicate of line 188. If you want to change it go ahead, otherwise I'll do it after merging this awesome PR 👍
There was a problem hiding this comment.
Let me double check if I messed up anything while rebasing.
There was a problem hiding this comment.
No, it's looking good. It's the same if twice, but I did it to follow the pattern that's used with other delegates. Right now applicationContinueUserActivityRestorationHandler is only used for one thing, but if something else will need to be added in the future, it will be more trivial and clear.
There was a problem hiding this comment.
Smart thinking, thanks for the explanation!
2 participants
Hi @EddyVerbruggen, I have started testing invites and dynamic links and ended up fixing them up. Here's a PR.
Added proper iOS 9+ handling for dynamic links
Extended returned data to include match confidence (specific for iOS)
Updated documentation