Skip to content

[WIP] dev: refactor fields modal#572

Open
Soare-Robert-Daniel wants to merge 40 commits intodevelopmentfrom
dev/modal-refactoring
Open

[WIP] dev: refactor fields modal#572
Soare-Robert-Daniel wants to merge 40 commits intodevelopmentfrom
dev/modal-refactoring

Conversation

@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Apr 8, 2026

Summary

Will affect visual aspect of the product

YES

Screenshots

CleanShot 2026-04-24 at 16 34 56@2x CleanShot 2026-04-24 at 16 35 23@2x CleanShot 2026-04-24 at 16 35 42@2x CleanShot 2026-04-24 at 16 35 56@2x CleanShot 2026-04-24 at 16 36 37@2x CleanShot 2026-04-24 at 16 37 04@2x CleanShot 2026-04-24 at 16 37 31@2x

Test instructions

Check before Pull Request is ready:

Closes #.

@Soare-Robert-Daniel Soare-Robert-Daniel changed the title Dev/modal refactoring [WIP] dev: refactor fields modal Apr 15, 2026
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review April 24, 2026 13:34
@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Apr 24, 2026
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Apr 24, 2026
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Apr 24, 2026
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Apr 24, 2026
@pirate-bot
Copy link
Copy Markdown
Contributor

pirate-bot commented Apr 24, 2026

Tip

You can preview the changes in the Playground

Plugin build for fe88cc7 is ready 🛎️!

@vytisbulkevicius
Copy link
Copy Markdown
Contributor

@Soare-Robert-Daniel,

In general it looks good but can we make view more compact? We reduced number of fields shown by default but they are taking so much space that you even need to scroll down to see the "Show Advanced" toggle while with the old design on the same view we were fitting all settings including those advanced. I think this also creates feeling of complexity when settings are taking full screen even though there are less of them now.

Especially these are taking way too much space iMO: image

Those fields don't need to take 50% of modal width, can we fit them better to save space?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants