refactor(github): deploy and publish on successful tests only

helmut-hoffer-von-ankershoffen · helmut-hoffer-von-ankershoffen · commit 67f062d15291 · 2025-04-26T12:35:08.000+02:00
diff --git a/.copier-answers.yml b/.copier-answers.yml
@@ -1,4 +1,4 @@
-_commit: v0.15.19-2-gec852c8
+_commit: v0.15.19-3-g3bf865b
 _src_path: .
 attestations_enabled: true
 author_email: helmuthva@gmail.com
diff --git a/.github/workflows/_codeql.yml b/.github/workflows/_codeql.yml
@@ -1,4 +1,4 @@
-name: Reusable CodeQL Analysis Workflow
+name: "CodeQL Analysis"
 
 on:
   workflow_call:
diff --git a/.github/workflows/_docker-publish.yml b/.github/workflows/_docker-publish.yml
@@ -1,4 +1,4 @@
-name: Reusable Docker Publish Workflow
+name: "Publish Docker Image"
 
 on:
   workflow_call:
diff --git a/.github/workflows/_package-publish.yml b/.github/workflows/_package-publish.yml
@@ -1,4 +1,4 @@
-name: Reusable Package Publish Workflow
+name: "Publish Package"
 
 on:
   workflow_call:
diff --git a/.github/workflows/_scheduled-test.yml b/.github/workflows/_scheduled-test.yml
@@ -1,4 +1,4 @@
-name: Reusable Scheduled Test Workflow
+name: "Scheduled Test"
 
 on:
   workflow_call:
diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml
@@ -1,4 +1,4 @@
-name: Reusable Test Workflow
+name: "Lint, Test and Audit"
 
 on:
   workflow_call:
diff --git a/.github/workflows/_vercel-preview.yml b/.github/workflows/_vercel-preview.yml
@@ -1,4 +1,4 @@
-name: Reusable Vercel Preview Workflow
+name: "Vercel Preview Deployment"
 
 on:
   workflow_call:
diff --git a/.github/workflows/_vercel-production.yml b/.github/workflows/_vercel-production.yml
@@ -1,4 +1,4 @@
-name: Reusable Vercel Production Workflow
+name: "Vercel Production Deployment"
 
 on:
   workflow_call:
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -28,7 +28,7 @@ jobs:
   # Package publish job - only runs on tags and depends on both test and CodeQL success
   package_publish:
 
-    needs: [test, codeql]
+    needs: [test]
 
     if: (startsWith(github.ref, 'refs/tags/v'))
     uses: ./.github/workflows/_package-publish.yml
@@ -37,7 +37,7 @@ jobs:
   # Docker publish job - only runs on tags and depends on both test and CodeQL success  
   docker_publish:
 
-    needs: [test, codeql]
+    needs: [test]
 
     if: (startsWith(github.ref, 'refs/tags/v'))
     uses: ./.github/workflows/_docker-publish.yml
@@ -57,7 +57,7 @@ jobs:
   vercel_production:
 
     # For production deployments from tags or releases, always depend on both test and CodeQL
-    needs: [test, codeql]
+    needs: [test]
 
     # The original workflow included both tags and release events
     if: (startsWith(github.ref, 'refs/tags/v') || github.event_name == 'release') && !contains(github.event.head_commit.message, '[skip ci]')
diff --git a/.github/workflows/codeql-scheduled.yml b/.github/workflows/codeql-scheduled.yml
@@ -1,4 +1,4 @@
-name: "CodeQL Scheduled"
+name: "Scheduled CodeQL"
 
 on:
   schedule:
diff --git a/.github/workflows/test-scheduled.yml b/.github/workflows/test-scheduled.yml
@@ -1,4 +1,4 @@
-name: "Test Scheduled"
+name: "Scheduled Testing"
 
 on:
   schedule:
diff --git a/template/.github/workflows/_docker-publish.yml.jinja b/template/.github/workflows/_docker-publish.yml.jinja
@@ -1,4 +1,4 @@
-name: Reusable Docker Publish Workflow
+name: "Publish Docker Image"
 
 on:
   workflow_call:
diff --git a/template/.github/workflows/_package-publish.yml.jinja b/template/.github/workflows/_package-publish.yml.jinja
@@ -1,4 +1,4 @@
-name: Reusable Package Publish Workflow
+name: "Publish Package"
 
 on:
   workflow_call:
diff --git a/template/.github/workflows/_scheduled-test.yml.jinja b/template/.github/workflows/_scheduled-test.yml.jinja
@@ -1,4 +1,4 @@
-name: Reusable Scheduled Test Workflow
+name: "Scheduled Test"
 
 on:
   workflow_call:
diff --git a/template/.github/workflows/_test.yml.jinja b/template/.github/workflows/_test.yml.jinja
@@ -1,4 +1,4 @@
-name: Reusable Test Workflow
+name: "Lint, Test and Audit"
 
 on:
   workflow_call:
diff --git a/template/.github/workflows/ci-cd.yml.jinja b/template/.github/workflows/ci-cd.yml.jinja
@@ -28,9 +28,9 @@ jobs:
   # Package publish job - only runs on tags and depends on both test and CodeQL success
   package_publish:
 {% if codeql_enabled %}
-    needs: [test, codeql]
+    needs: [test]
 {% else %}
-    needs: test
+    needs: [test]
 {% endif %}
     if: (startsWith(github.ref, 'refs/tags/v'))
     uses: ./.github/workflows/_package-publish.yml
@@ -39,9 +39,9 @@ jobs:
   # Docker publish job - only runs on tags and depends on both test and CodeQL success  
   docker_publish:
 {% if codeql_enabled %}
-    needs: [test, codeql]
+    needs: [test]
 {% else %}
-    needs: test
+    needs: [test]
 {% endif %}
     if: (startsWith(github.ref, 'refs/tags/v'))
     uses: ./.github/workflows/_docker-publish.yml
@@ -63,9 +63,9 @@ jobs:
   vercel_production:
 {% if codeql_enabled %}
     # For production deployments from tags or releases, always depend on both test and CodeQL
-    needs: [test, codeql]
+    needs: [test]
 {% else %}
-    needs: test
+    needs: [test]
 {% endif %}
     # The original workflow included both tags and release events
     if: (startsWith(github.ref, 'refs/tags/v') || github.event_name == 'release') && !contains(github.event.head_commit.message, '[skip ci]')
diff --git a/template/.github/workflows/codeql-scheduled.yml.jinja b/template/.github/workflows/codeql-scheduled.yml.jinja
@@ -1,4 +1,4 @@
-name: "CodeQL Scheduled"
+name: "Scheduled CodeQL"
 
 on:
   schedule:
diff --git a/template/.github/workflows/test-scheduled.yml.jinja b/template/.github/workflows/test-scheduled.yml.jinja
@@ -1,4 +1,4 @@
-name: "Test Scheduled"
+name: "Scheduled Testing"
 
 on:
   schedule:
diff --git a/template/.github/workflows/{% if codeql_enabled %}_codeql.yml{% endif %} b/template/.github/workflows/{% if codeql_enabled %}_codeql.yml{% endif %}
@@ -1,4 +1,4 @@
-name: Reusable CodeQL Analysis Workflow
+name: "CodeQL Analysis"
 
 on:
   workflow_call:
diff --git a/template/.github/workflows/{% if vercel_function_enabled %}_vercel-preview.yml{% endif %} b/template/.github/workflows/{% if vercel_function_enabled %}_vercel-preview.yml{% endif %}
@@ -1,4 +1,4 @@
-name: Reusable Vercel Preview Workflow
+name: "Vercel Preview Deployment"
 
 on:
   workflow_call:
diff --git a/template/.github/workflows/{% if vercel_function_enabled %}_vercel-production.yml{% endif %} b/template/.github/workflows/{% if vercel_function_enabled %}_vercel-production.yml{% endif %}
@@ -1,4 +1,4 @@
-name: Reusable Vercel Production Workflow
+name: "Vercel Production Deployment"
 
 on:
   workflow_call:

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-_commit: v0.15.19-2-gec852c8`
	`1`	`+_commit: v0.15.19-3-g3bf865b`
`2`	`2`	`_src_path: .`
`3`	`3`	`attestations_enabled: true`
`4`	`4`	`author_email: helmuthva@gmail.com`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Reusable CodeQL Analysis Workflow`
	`1`	`+name: "CodeQL Analysis"`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`workflow_call:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Reusable Docker Publish Workflow`
	`1`	`+name: "Publish Docker Image"`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`workflow_call:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Reusable Package Publish Workflow`
	`1`	`+name: "Publish Package"`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`workflow_call:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Reusable Scheduled Test Workflow`
	`1`	`+name: "Scheduled Test"`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`workflow_call:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Reusable Test Workflow`
	`1`	`+name: "Lint, Test and Audit"`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`workflow_call:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Reusable Vercel Preview Workflow`
	`1`	`+name: "Vercel Preview Deployment"`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`workflow_call:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Reusable Vercel Production Workflow`
	`1`	`+name: "Vercel Production Deployment"`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`workflow_call:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: "CodeQL Scheduled"`
	`1`	`+name: "Scheduled CodeQL"`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`schedule:`