Affected file: sk/microsoft-agent-framework/skills/azure-architecture-autopilot/scripts/cli.py
What I hit
I passed in a service payload with {"private": "false"} and the generated output still flagged it as private.
I’m thinking this comes from svc["private"] = bool(svc["private"]) where any non-empty string is cast to True.
Repro
- Pass
{"private": "false"} into the service normalization path.
- Inspect output and confirm
private remains True.
Expected
String booleans should map semantically ("true", "false", etc.), not by truthy casting.
Actual
"false" and other non-empty values are interpreted as true.
Suggested fix
Implement explicit string normalization for true/false inputs before assignment.
Affected file:
sk/microsoft-agent-framework/skills/azure-architecture-autopilot/scripts/cli.pyWhat I hit
I passed in a service payload with
{"private": "false"}and the generated output still flagged it as private.I’m thinking this comes from
svc["private"] = bool(svc["private"])where any non-empty string is cast toTrue.Repro
{"private": "false"}into the service normalization path.privateremainsTrue.Expected
String booleans should map semantically (
"true","false", etc.), not by truthy casting.Actual
"false"and other non-empty values are interpreted as true.Suggested fix
Implement explicit string normalization for true/false inputs before assignment.