You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: always run vis-test jobs so required checks report status (#18392)
## Problem
When `AFFECTED_TAGS` computes to `NONE` (e.g. a PR that only touches
`shared-ui-components` or other non-vis-test code), the WebGL2 and
WebGPU visualization test jobs were **skipped entirely** via job-level
conditions:
```yaml
condition: and(succeeded(), ne(dependencies.Build.outputs['ComputeVisTags.AFFECTED_TAGS'], 'NONE'))
```
This meant Azure DevOps never reported a status for these jobs. Since
they are **required checks**, the PR was blocked from merging — even
though there were no relevant tests to run.
**Example:** #18389 — WebGL2 job shows as "expected" but never runs:
[build
logs](https://dev.azure.com/babylonjs/ContinousIntegration/_build/results?buildId=52627&view=logs&jobId=41c91092-7737-59ad-bca4-0f81503fea43&j=e5cc6727-28b8-51a4-d48e-c84cfcad289b)
## Fix
- **Remove the job-level `NONE` condition** — both vis-test jobs now
always run, so Azure DevOps always reports a status (satisfying the
required check).
- **Add step-level conditions** on `npm install` and the BrowserStack
test step: `condition: ne(variables['AFFECTED_TAGS'], 'NONE')` — skips
the expensive work when there are no affected tests.
- **Add an echo step** (`"Skip — no affected tests"`) that runs when
`NONE` — produces a clear green status in the build log.
The job runs, reports green, and the required check is satisfied. No
BrowserStack sessions are wasted.
## Changes
- `.azure-pipelines/ci-monorepo.yml` — WebGL2 and WebGPU job conditions
0 commit comments